Skip to content

Replace opacity with a lighter color for the disabled state of controls - #630

Merged
prushforth merged 1 commit into
Maps4HTML:mainfrom
Malvoz:remove-opacity-disabled-controls
Apr 20, 2023
Merged

Replace opacity with a lighter color for the disabled state of controls#630
prushforth merged 1 commit into
Maps4HTML:mainfrom
Malvoz:remove-opacity-disabled-controls

Conversation

@Malvoz

@Malvoz Malvoz commented Dec 7, 2021

Copy link
Copy Markdown
Member

Replaces opacity with a lighter color (same as for leaflet-disabled) on disabled controls.

Fixes #629.

Preview

  • Fixes contrast issue on disabled controls

    Before:

    low-contrast

    After:

    ok-contrast

  • Fixes outline visibility on disabled controls

    Before:

    outline-disabled-before

    After:

    outline-disabled-after

  • Fixes a stacking context issue in the layer control on drag.
    This bug doesn't seem to be present anymore, maybe something changed, or it was a browser bug.

    Before:

    stacking-context-bug

    After:

    stacking-context-bug-fixed

@Malvoz
Malvoz requested a review from prushforth December 7, 2021 14:20
@Malvoz Malvoz changed the title Remove applied opacity on disabled controls Replace opacity with a lighter color for the disabled state of controls Jan 12, 2022
@prushforth
prushforth force-pushed the remove-opacity-disabled-controls branch from 0b2187d to b0badd1 Compare April 20, 2023 14:33

@prushforth prushforth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@prushforth
prushforth merged commit 1988836 into Maps4HTML:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opacity issues on disabled controls

2 participants